search for: generate_wrapper_script

...one additional help when debugging failed conversions. --- p2v/conversion.c | 5 +++++ p2v/virt-p2v.pod | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/p2v/conversion.c b/p2v/conversion.c index 3c379cb..b8bab34 100644 --- a/p2v/conversion.c +++ b/p2v/conversion.c @@ -1061,6 +1061,11 @@ generate_wrapper_script (struct config *config, const char *remote_dir, fprintf (fp, "\n"); fprintf (fp, + "# Log the environment where virt-v2v will run.\n"); + fprintf (fp, "printenv > environment\n"); + fprintf (fp, "\n"); + + fprintf (fp, &quo...

(I don't have a BZ# for this yet, but I'm expecting it to be filed as an RFE) Currently if the user is in the virt-p2v GUI and cancels the conversion, all that happens is we abruptly close the ssh session to virt-v2v. That is bad .. possibly (or maybe not). But in any case there is an alternative: we can send a ^C key to the virt-v2v process, which it could catch and handle gracefully,

After debugging a virt-p2v issue with a customer in the middle of the night on Tuesday, I felt it would have been helpful to know exactly which version(s) of virt-p2v and virt-v2v they were using. That wasn't very clear from the log file I was provided with, so this change makes sure the information is included every time. Rich.

In the run dialog, I have implemented an ANSI colour escape sequence interpreter, so that colours displayed by the remote virt-v2v are now shown to the user. (https://bugzilla.redhat.com/show_bug.cgi?id=1314244) This requires virt-v2v to send colours. It wasn't doing that because the output was a pipe (as we capture the output into the log file). So I added a global --colours option to make

...chine to run virtualized on KVM, > > managed by libvirt, OpenStack, oVirt, Red Hat Virtualisation > > (RHV), or one of the other targets supported by virt-v2v(1). > > In fact, `openstack` is one of the targets of `virt-v2v`. According > to the file `p2v/conversion.c`, function `generate_wrapper_script`, > the output mode of `virt-v2v` can be set to `glance`. The manpage of > `virt-v2v` claims > > > only -o openstack should be used normally. > > But even if `-o glance` was appropriate, there's no provision for > setting additional command line flags such as `-oo …` in...

...a separate I<-oo OPTION=VALUE> +option on the virt-v2v command line. See L<virt-v2v(1)/OPTIONS>.", + ), ); # Clean up the program name. diff --git a/conversion.c b/conversion.c index b9af47deda74..cc6387c88af8 100644 --- a/conversion.c +++ b/conversion.c @@ -526,6 +526,15 @@ generate_wrapper_script (struct config *config, const char *remote_dir, print_quoted (fp, config->output.storage); } + if (config->output.misc) { /* -oo */ + size_t i; + + for (i = 0; config->output.misc[i]; ++i) { + fprintf (fp, " -oo "); + print_quoted (fp, config->output...

These are a prelude to fixing https://bugzilla.redhat.com/show_bug.cgi?id=1590220 A lot of the virt-p2v configuration code was duplicated manually. These changes make sure that most of it is generated. Rich.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1792141 Let the user pass "-oo" options from the kernel cmdline and from the GUI to virt-v2v. This is primarily useful with the OpenStack output mode, so reenable that mode. Cc: Alban Lecorps <alban.lecorps at ubisoft.com> Laszlo Alban Lecorps (1): Introduce "p2v.output.misc" for passing "-oo" options

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am