search for: fuse_opt_free_args

...FUSE 'args'. */ - /* XXX we don't have a program name */ - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { + if (fuse_opt_add_arg (&args, g->program) == -1) { arg_error: perrorf (g, _("fuse_opt_add_arg: %s"), localmountpoint); fuse_opt_free_args (&args); -- 2.9.3

...FUSE 'args'. */ - /* XXX we don't have a program name */ - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { + if (fuse_opt_add_arg (&args, g->program) == -1) { arg_error: perrorf (g, _("fuse_opt_add_arg: %s"), localmountpoint); fuse_opt_free_args (&args); -- 2.7.4

...- /* XXX we don't have a program name */ > - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { > + if (fuse_opt_add_arg (&args, g->program) == -1) { > arg_error: > perrorf (g, _("fuse_opt_add_arg: %s"), localmountpoint); > fuse_opt_free_args (&args); ACK. I think there is a bug in our documentation, see patch below. Rich. >From 935beccab9180b5883c6a214c739a161802b4853 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" <rjones@redhat.com> Date: Fri, 3 Feb 2017 15:08:52 +0000 Subject: [PATCH] lib: g->progra...

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

...y) error. > + } > + > + /* Create the FUSE handle. */ > + fuse = fuse_new (ch, &fuse_args, > + &fuse_operations, sizeof fuse_operations, NULL); > + if (!fuse) { > + perror ("fuse_new"); > + exit (EXIT_FAILURE); > + } > + fuse_opt_free_args (&fuse_args); > + > + /* Catch signals since they can leave the mountpoint in a funny > + * state. To exit the program callers must use ‘fusermount -u’. We > + * also must be careful not to call exit(2) in this program until we > + * have unmounted the filesystem below....

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

...gt;= 0) + fcntl (fd, F_SETFD, flags & ~FD_CLOEXEC); + } + + /* Create the FUSE handle. */ + fuse = fuse_new (ch, &fuse_args, + &fuse_operations, sizeof fuse_operations, NULL); + if (!fuse) { + perror ("fuse_new"); + exit (EXIT_FAILURE); + } + fuse_opt_free_args (&fuse_args); + + /* Catch signals since they can leave the mountpoint in a funny + * state. To exit the program callers must use ‘fusermount -u’. We + * also must be careful not to call exit(2) in this program until we + * have unmounted the filesystem below. + */ + memset (&sa...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.