search for: exit_on_error

...period_time = 20000; snd_pcm_uframes_t buffer_size; snd_pcm_uframes_t period_size; int flags; @@ -753,9 +753,9 @@ static DWORD wodOpen(WORD wDevID, LPWAVE ALSA_getFormat(wwo->format.Format.wFormatTag)); dir=0; - EXIT_ON_ERROR( snd_pcm_hw_params_set_buffer_time_near(pcm, hw_params, &buffer_time, &dir), MMSYSERR_INVALPARAM, "unable to set buffer time"); + //EXIT_ON_ERROR( snd_pcm_hw_params_set_buffer_time_near(pcm, hw_params, &buffer_time, &dir), MMSYSERR_INVALPARAM, "unable to set buffer...

...exit (EXIT_FAILURE); } continue; } @@ -639,14 +639,14 @@ script (int prompt) len = strcspn (p, "\""); if (p[len] == '\0') { fprintf (stderr, _("%s: unterminated double quote\n"), program_name); - if (exit_on_error) exit (1); + if (exit_on_error) exit (EXIT_FAILURE); goto next_command; } if (p[len+1] && (p[len+1] != ' ' && p[len+1] != '\t')) { fprintf (stderr, _("%s: command arguments not separated by whi...

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

...amp;hello)) { fprintf (stderr, _("guestfish: protocol error: could not send initial greeting to server\n")); - fclose (fp); xdr_destroy (&xdr); + fclose (fp); return -1; } @@ -249,8 +249,8 @@ rc_remote (int pid, const char *cmd, int argc, char *argv[], call.exit_on_error = exit_on_error; if (!xdr_guestfish_call (&xdr, &call)) { fprintf (stderr, _("guestfish: protocol error: could not send initial greeting to server\n")); - fclose (fp); xdr_destroy (&xdr); + fclose (fp); return -1; } xdr_destroy (&xdr); @@ -260...

...ting/notify.c Compiling printing/printing_db.c Linking bin/smbcontrol Compiling nsswitch/winbind_nss_solaris.c Linking nsswitch/libnss_winbind.shared_libraries_disabled /bin/sh: shared-libraries-disabled: not found. gmake: *** [nsswitch/libnss_winbind.shared_libraries_disabled] Error 127 ++ exit_on_error 2 ++ '[' 2 -ne 0 ']' ++ '[' -n '' ']' ++ exit 2 Exiting on error 2 Any help is greatly appreciated. Thanks -Vallabha

...+ "Type: 'help' for help with commands\n" + " 'quit' to quit the shell\n" + "\n")); while (!quit) { char *pipe = NULL; @@ -552,11 +552,11 @@ script (int prompt) r = system (buf+1); if (exit_on_error) { - if (r == -1 || - (WIFSIGNALED (r) && - (WTERMSIG (r) == SIGINT || WTERMSIG (r) == SIGQUIT)) || - WEXITSTATUS (r) != 0) - exit (1); + if (r == -1 || + (WIFSIGNALED (r) && + (WTERMSIG (r) == SIGINT || WTERMSIG (r) == SIGQUIT)) || +...

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

...guestfs_int_program_name, + guestfs_int_program_name, guestfs_int_program_name, + guestfs_int_program_name); } exit (status); } @@ -1090,7 +1091,7 @@ cmdline (char *argv[], size_t optind, size_t argc) if (optind == argc) { if (issue_command (cmd, params, NULL, exit_on_error) == -1 && exit_on_error) - exit (EXIT_FAILURE); + exit (EXIT_FAILURE); } else { argv[optind] = NULL; if (issue_command (cmd, params, NULL, exit_on_error) == -1 && exit_on_error) diff --git a/fish/inspect.c b/fish/inspect.c index eb5ecc6..97e46ae 100644 --- a...

...me foreign chm files 18083 Metatrader: doesn't respect charts sorting/sequency when restarted 19100 Age of Wonders Shadow Magic: Game doesn't launch! 20755 Minor display problems in Mafia 21226 MetaEditor has black rows in the text editor. 21694 MotorM4X fails to run 22034 EXIT_ON_ERROR should use ERR instead of WARN in winealsa.drv 22065 HeadOverHeels crashes 22308 Downloadable content is unauthorized and disabled when logged in to Dragon Age: Origins server 22350 package Mono so it can be included in a default Wine install 22696 RCT2 crashes when changing screen reso...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

...else { editor = getenv ("EDITOR"); diff --git a/fish/fish.c b/fish/fish.c index 3ab09b5..9a89f55 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -843,40 +843,40 @@ issue_command (const char *cmd, char *argv[], const char *pipecmd) r = rc_remote (remote_control, cmd, argc, argv, exit_on_error); /* Otherwise execute it locally. */ - else if (strcasecmp (cmd, "help") == 0) { + else if (STRCASEEQ (cmd, "help")) { if (argc == 0) list_commands (); else display_command (argv[0]); r = 0; } - else if (strcasecmp (cmd, "quit")...

These two patches are probably not completely independent, but separating them is a lot of work. With *both* patches applied, all the tests and extra-tests pass. That's no guarantee however that there isn't a mistake, so I don't think this patch is a candidate for the 1.16 branch, until it's had a lot more testing in development. Rich.