search for: do_close

Folks, I've noticed poor performance using sftp. If anyone has any advice on how to improve performance, I'd like to hear it. Test simply involved transferring a single 143MB MP3 file using defaults for all the program configs. The opensshd 3.0.2p1 server is used in all tests. Software: openssh suite 3.0.2p1 psftp (putty sftp client) latest dev snapshot pscp (putty scp client) latest

...1 file changed, 51 insertions(+), 24 deletions(-) diff --git a/lib/handle.c b/lib/handle.c index 449ab42a6..19caad813 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -43,6 +43,7 @@ static int shutdown_backend (guestfs_h *g, int check_for_errors); static void close_handles (void); +static void do_close (guestfs_h *g, int ignore_recursive); gl_lock_define_initialized (static, handles_lock); static guestfs_h *handles = NULL; @@ -323,15 +324,7 @@ guestfs_impl_parse_environment_list (guestfs_h *g, char * const *strings) void guestfs_close (guestfs_h *g) { - struct hv_param *hp, *hp_next; g...

...+ xfree(data); - if (status == SSH2_FX_EOF) - break; + if (len == req[reply].len) + remove_request(req, &num_req, reply); else { - error("Couldn't read from remote " - "file \"%s\" : %s", remote_path, - fx2txt(status)); - do_close(fd_in, fd_out, handle, handle_len); - goto done; + /* Resend the request for the missing data */ + req[reply].id = msg_id++; + req[reply].len -= len; + req[reply].offset += len; + send_request(fd_out, handle, handle_len, + SSH2_FXP_READ, &req[reply], &msg); }...

...sion_zstd_out_stream; + u_int64_t compress_zstd_in_raw; + u_int64_t compress_zstd_in_comp; + u_int64_t compress_zstd_out_raw; + u_int64_t compress_zstd_out_comp; #endif int compression_in_started; int compression_out_started; @@ -604,11 +615,11 @@ ssh_packet_close_internal(struct ssh *ssh, int do_close) state->newkeys[mode] = NULL; ssh_clear_newkeys(ssh, mode); /* next keys */ } -#ifdef WITH_ZLIB /* compression state is in shared mem, so we can only release it once */ if (do_close && state->compression_buffer) { sshbuf_free(state->compression_buffer); - if (state...

--- ../openssh/sftp-client.c Fri Feb 9 08:44:24 2001 +++ sftp-client.c Fri Feb 9 19:14:01 2001 @@ -331,7 +331,7 @@ error("Couldn't read directory: %s", fx2txt(status)); do_close(fd_in, fd_out, handle, handle_len); - return(NULL); + return(0); } } else if (type != SSH2_FXP_NAME) fatal("Expected SSH2_FXP_NAME(%d) packet, got %d",

I added ZSTD support to OpenSSH roughly three years ago and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port

I hacked zstd support into OpenSSH a while ago and just started to clean it up in the recent days. The cleanup includes configuration support among other things that I did not have. During testing I noticed the following differences compared to zlib: - highly interactive shell output (as in refreshed at a _very_ high rate) may result in higher bandwidth compared to zlib. Since zstd is quicker

I added ZSTD support to OpenSSH roughly over a year and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port

...@ -724,6 +729,11 @@ return(-1); } + totalbytes = a->size; + curfile = remote_path; + if (progressbar) + (progressbar)(0); + /* Read from remote and write to local */ offset = 0; for(;;) { @@ -785,6 +795,7 @@ offset += len; xfree(data); + statbytes = offset; } status = do_close(fd_in, fd_out, handle, handle_len); @@ -807,15 +818,18 @@ } done: + if (progressbar) + (progressbar)(1); close(local_fd); buffer_free(&msg); xfree(handle); + return status; } int do_upload(int fd_in, int fd_out, char *local_path, char *remote_path, - int pflag) + int...

...goto fail; } if ((size_t)st.st_size > size) { error("Unable to resume download of \"%s\": " "local file is larger than remote", local_path); fail: do_close(conn, handle, handle_len); buffer_free(&msg); free(handle); return -1; in the fail label, local_fd is not closed in case open() call was successful. -- You are receiving this mail because: You are watching the assignee o...

...by 0x4F607B8: run_Rmainloop (main.c:986) ==14875== Address 0x907f1d8 is 136 bytes inside a block of size 448 free'd ==14875== at 0x4C25F7B: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==14875== by 0x4EB0282: con_destroy (connections.c:3086) ==14875== by 0x4EB03B3: do_close (connections.c:3105) ==14875== by 0x4F795E4: do_internal (names.c:1236) ==14875== by 0x4F15F63: Rf_eval (eval.c:471) ==14875== by 0x4F19D7F: Rf_evalList (eval.c:1840) == A little more revealing, with two surprises noted, is > f <- tempdir() > a <- .A$new(con=file(f, "r...

...90) ==13521== by 0x5D4D21: do_flush (gzio.c:757) ==13521== by 0x5D4F39: gzclose (gzio.c:991) ==13521== by 0x44AC22: gzfile_close (connections.c:1035) ==13521== by 0x44A703: con_close1 (connections.c:2256) ==13521== by 0x44A742: con_close (connections.c:2283) ==13521== by 0x44D3A3: do_close (connections.c:2303) ==13521== by 0x4C43BB: do_internal (names.c:1089) ==13521== by 0x4978F5: Rf_eval (eval.c:398) ==13521== by 0x497F0D: Rf_evalList (eval.c:1400) > invisible(options(echo = TRUE)) > > foo <- 2 > save(foo, file = "foo.Rdata") > > > pr...

...OS/Version: All Status: NEW Severity: minor Priority: P2 Component: sftp AssignedTo: bitbucket at mindrot.org ReportedBy: sworley at chkno.net Created an attachment (id=1362) --> (http://bugzilla.mindrot.org/attachment.cgi?id=1362) do_close(handle) on local file open failure I get "Couldn't get handle: Failure" after N failures to open local files for writing where N = 100 on OpenBSD and N = 200 on GNU/Linux. To reproduce: bash-3.2$ ssh otherhost otherhost$ mkdir test otherhost$ cd test otherhost$ touch {1000..1120} o...

...-723,6 +728,11 @@ return(-1); } + totalbytes = a->size; + curfile = remote_path; + if (progressbar) + (progressbar)(0); + /* Read from remote and write to local */ offset = 0; for (;;) { @@ -784,6 +794,7 @@ offset += len; xfree(data); + statbytes = offset; } status = do_close(fd_in, fd_out, handle, handle_len); @@ -802,15 +813,21 @@ } done: + if (progressbar) + (progressbar)(1); close(local_fd); buffer_free(&msg); xfree(handle); + statbytes = 0; + totalbytes = 0; + curfile = NULL; + return status; } int do_upload(int fd_in, int fd_out, char *loc...

v2 -> v3: - Lots of code cleanups. - Documentation. However this is still spooling the file into a temporary before the upload. It turns out that fixing this is going to require a small change to qemu. Rich.

Hello Thomas, I am writting to you because I have some questions about R-(D)COM. The first one is whether it can compiled using the MINGW C compiler, that is recomended by B. Ripley to compile R under Windows. The other questions are: - How can I open/close connections directly from C/C++? - Do you know about a free Visual Basic compiler? The final purpose of using R-(D)COM is to create a

...3 ds=0023 es=0023 fs=003b gs=0000 efl=00000246 Call stack: 7C911E58 ntdll.dll:7C911E58 RtlInitializeCriticalSection 7C910D5C ntdll.dll:7C910D5C wcsncpy 77C2C2DE msvcrt.dll:77C2C2DE free 1004BFB0 R.dll:1004BFB0 do_isseekable 1004C051 R.dll:1004C051 con_close 1004D33E R.dll:1004D33E do_close 100A8E41 R.dll:100A8E41 do_internal 1008494A R.dll:1008494A Rf_eval 10085595 R.dll:10085595 Rf_evalList 10084993 R.dll:10084993 Rf_eval 100875AB R.dll:100875AB Rf_applyClosure 100A9361 R.dll:100A9361 do_internal 100A99A5 R.dll:100A99A5 Rf_usemethod 100A9E1A R.dll:100A9E1A do_usemeth...

https://bugzilla.mindrot.org/show_bug.cgi?id=1698 Summary: Connection stalls on PTY allocation failure Product: Portable OpenSSH Version: 5.3p1 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: unassigned-bugs at mindrot.org ReportedBy:

...ublic: bool __thiscall RemoteConnection::ready_to_read(void)const " (?ready_to_read at RemoteConnection@@QBE_NXZ) ???? libnet.lib(tcpclient.obj) : error LNK2001: ????????? __imp__select at 20 libnet.lib(progclient.obj) : error LNK2019: ????????? "protected: void __thiscall RemoteDatabase::do_close(void)" (?do_close at RemoteDatabase@@IAEXXZ)??????? "public: virtual __thiscall ProgClient::~ProgClient(void)" (??1ProgClient@@UAE at XZ) ???? libnet.lib(tcpclient.obj) : error LNK2001: ????????? "protected: void __thiscall RemoteDatabase::do_close(void)" (?do_close at Remo...

...-1); } + file_size = a->size; + filename = remote_path; + progressmeter(-1, offset, file_size, filename); + signal(SIGALRM, updateprogressmeter); + alarm(PROGRESSTIME); + /* Read from remote and write to local */ offset = 0; for (;;) { @@ -786,6 +808,7 @@ xfree(data); } status = do_close(fd_in, fd_out, handle, handle_len); + progressmeter(1, offset, file_size, filename); /* Override umask and utimes if asked */ if (pflag && fchmod(local_fd, mode) == -1) @@ -814,7 +837,6 @@ { int local_fd; u_int handle_len, id; - u_int64_t offset; char *handle; Buffer msg; s...