search for: debug_core_pattern

This is a repost of a previously posted set. It's been updated following review comments. [PATCH 1/4] Add a core_pattern debug command Added missing return statements. [PATCH 2/4] Call sync after guestfsd exits Remove redundant sleep 1; sync [PATCH 3/4] Shut down the appliance cleanly [PATCH 4/4] Ignore launch() error in virt-rescue These were previously 2 patches. They are otherwise

[PATCH 1/3] Add a core_pattern debug command The first patch is just a rework of Rich's earlier core dump patch. It turns it into a debug subcommand so it can be called at any time. This also has the advantage of explicitly labelling an extremely untidy API as debug. [PATCH 2/3] Call sync after guestfsd exits The second patch seems to be required for cores to be dumped reliably. I was able to

These two patches are probably not completely independent, but separating them is a lot of work. With *both* patches applied, all the tests and extra-tests pass. That's no guarantee however that there isn't a mistake, so I don't think this patch is a candidate for the 1.16 branch, until it's had a lot more testing in development. Rich.

...++++---- daemon/sync.c | 2 +- daemon/uuids.c | 4 ++-- daemon/xfs.c | 16 ++++++++-------- 12 files changed, 40 insertions(+), 40 deletions(-) diff --git a/daemon/debug.c b/daemon/debug.c index 92f5aa6..a210db1 100644 --- a/daemon/debug.c +++ b/daemon/debug.c @@ -588,7 +588,7 @@ debug_core_pattern (const char *subcmd, size_t argc, char *const *const argv) } const char *pattern = argv[0]; - const size_t pattern_len = strlen(pattern); + const size_t pattern_len = strlen (pattern); #define CORE_PATTERN "/proc/sys/kernel/core_pattern" int fd = open (CORE_PATTERN, O_WRON...

Hi, this patch series improves the way /usr filesystems are handled: tag them appropriately, so later on we can find them and merge results they contain directly back for the root filesystem. The series includes also a new private debug API, and its usage to fix the resolution of /dev/mapper/.. devices found in fstab; without it, LVM /usr filesystems are not recognized as belonging to their