search for: createvm

The @SD_UUID@ pattern was not being replaced correctly. Thanks: Daniel Erez. --- v2v/rhv-upload-createvm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/rhv-upload-createvm.py b/v2v/rhv-upload-createvm.py index a34627ec8..1d0e8c95d 100644 --- a/v2v/rhv-upload-createvm.py +++ b/v2v/rhv-upload-createvm.py @@ -70,7 +70,7 @@ sds_service = system_service.storage_domains_service()...

...the storage domains attached to the data center found - similarly, look for the specified cluster among the ones attached to the data center found When everything is found, return the UUID of the storage domain, and of the cluster back to virt-v2v, which will store them. Similarly, rework the createvm script to directly get the requested cluster, instead of looking for it once again. Also, since the UUID of the storage domain is available in virt-v2v already, use it directly instead of using a placeholder. This should fix a number of issues: - unexisting/unattached storage domains are rejected...

For interest only, here is the patch required to make -o rhv-upload work with Python 2 (for RHEL 7). I don't think we want this upstream. A couple of remarks: * It's supposed to be possible to add ‘coding: utf-8’ to the top of .py files to make Python 2 accept that the file is UTF-8 (otherwise it gives an error on loading). However I added this and it didn't appear to make any

...sertions(+), 7 deletions(-) diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 34cad197b..88b31f86c 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -143,12 +143,12 @@ SOURCES_C = \ # These files are generated and contain rhv-upload-*.py embedded as an # OCaml string. -output_rhv_upload_createvm_source.ml: rhv-upload-createvm.py - ./embed.sh code $^ $@ -output_rhv_upload_plugin_source.ml: rhv-upload-plugin.py - ./embed.sh code $^ $@ -output_rhv_upload_precheck_source.ml: rhv-upload-precheck.py - ./embed.sh code $^ $@ +output_rhv_upload_createvm_source.ml: $(srcdir)/rhv-upload-createvm.py +...

...Output_rhv_upload_vmcheck_source.code in > let plugin_script = > - Python_script.create ~name:"rhv-upload-plugin.py" > + Python_script.create ~name:"rhv-upload-plugin.py" ~tmpdir > Output_rhv_upload_plugin_source.code in > let createvm_script = > - Python_script.create ~name:"rhv-upload-createvm.py" > + Python_script.create ~name:"rhv-upload-createvm.py" ~tmpdir > Output_rhv_upload_createvm_source.code in > let deletedisks_script = > - Python_script.create ~...

Add an optional parameter for Python_script.create, to specific the temporary directory to use instead of creating a new one. --- v2v/python_script.ml | 13 ++++++++----- v2v/python_script.mli | 5 ++++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/v2v/python_script.ml b/v2v/python_script.ml index 3159373a1..6bb14ec1f 100644 --- a/v2v/python_script.ml +++

...ython imports Revamp check for Python code style config.sh.in | 1 + m4/guestfs-progs.m4 | 3 + .../ovirtsdk4/__init__.py | 39 +++++-- .../ovirtsdk4/types.py | 40 ++++--- v2v/rhv-upload-createvm.py | 20 ++-- v2v/rhv-upload-deletedisks.py | 14 +-- v2v/rhv-upload-plugin.py | 105 ++++++++++++------ v2v/rhv-upload-precheck.py | 18 ++- v2v/rhv-upload-vmcheck.py | 16 ++- v2v/test-v2v-python-sy...

Mainly minor fixes and code cleanups over the v4 patch. There are still several problems with this patch, but it is in a reviewable state, especially the Python code. Rich.

...| 26 ++- v2v/cmdline.ml | 38 ++++ v2v/embed.sh | 45 ++++ v2v/output_rhv_upload.ml | 330 ++++++++++++++++++++++++++++++ v2v/output_rhv_upload.mli | 27 +++ v2v/output_rhv_upload_createvm_source.mli | 19 ++ v2v/output_rhv_upload_plugin_source.mli | 19 ++ v2v/output_rhv_upload_precheck_source.mli | 19 ++ v2v/rhv-upload-createvm.py | 85 ++++++++ v2v/rhv-upload-plugin.py | 248 ++++++++++++++++++++++ v2v/rhv-upload-precheck.py |...

...6 ++- > v2v/cmdline.ml | 38 ++++ > v2v/embed.sh | 45 ++++ > v2v/output_rhv_upload.ml | 330 > ++++++++++++++++++++++++++++++ > v2v/output_rhv_upload.mli | 27 +++ > v2v/output_rhv_upload_createvm_source.mli | 19 ++ > v2v/output_rhv_upload_plugin_source.mli | 19 ++ > v2v/output_rhv_upload_precheck_source.mli | 19 ++ > v2v/rhv-upload-createvm.py | 85 ++++++++ > v2v/rhv-upload-plugin.py | 248 ++++++++++++++++++++++ > v2v/rhv-upload-prec...

v5 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00032.html There is only a single patch in this version because the other patches went upstream. This patch adds the virt-v2v -o rhv-upload mode (https://bugzilla.redhat.com/show_bug.cgi?id=1557273). Compared to v5, this adds the ability to make zero, trim and flush requests to the oVirt imageio server

...le.am | 28 ++- v2v/cmdline.ml | 46 ++++ v2v/embed.sh | 45 ++++ v2v/output_rhv_upload.ml | 339 +++++++++++++++++++++++++ v2v/output_rhv_upload.mli | 27 ++ v2v/output_rhv_upload_createvm_source.mli | 19 ++ v2v/output_rhv_upload_plugin_source.mli | 19 ++ v2v/output_rhv_upload_precheck_source.mli | 19 ++ v2v/rhv-upload-createvm.py | 85 +++++++ v2v/rhv-upload-plugin.py | 394 ++++++++++++++++++++++++++++++ v2v/rhv-upload-precheck.py...

...| 26 ++- > v2v/cmdline.ml | 38 ++++ > v2v/embed.sh | 45 ++++ > v2v/output_rhv_upload.ml | 330 ++++++++++++++++++++++++++++++ > v2v/output_rhv_upload.mli | 27 +++ > v2v/output_rhv_upload_createvm_source.mli | 19 ++ > v2v/output_rhv_upload_plugin_source.mli | 19 ++ > v2v/output_rhv_upload_precheck_source.mli | 19 ++ > v2v/rhv-upload-createvm.py | 85 ++++++++ > v2v/rhv-upload-plugin.py | 248 ++++++++++++++++++++++ > v2v/rhv-upload-prec...

..._upload_deletedisks_source.mli create mode 100644 v2v/rhv-upload-deletedisks.py diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 067e11049..84b56d259 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -25,6 +25,7 @@ BUILT_SOURCES = \ $(generator_built) \ config.ml \ output_rhv_upload_createvm_source.ml \ + output_rhv_upload_deletedisks_source.ml \ output_rhv_upload_plugin_source.ml \ output_rhv_upload_precheck_source.ml \ output_rhv_upload_vmcheck_source.ml @@ -35,6 +36,7 @@ EXTRA_DIST = \ copy_to_local.mli \ embed.sh \ rhv-upload-createvm.py \ + rhv-upload-deletedisks.py \...

...-upload: cancel disk transfer on failure v2v/Makefile.am | 14 ++- v2v/output_rhv_upload.ml | 106 ++++++++++++++----- v2v/output_rhv_upload_deletedisks_source.mli | 19 ++++ v2v/output_rhv_upload_vmcheck_source.mli | 19 ++++ v2v/rhv-upload-createvm.py | 11 +- v2v/rhv-upload-deletedisks.py | 71 +++++++++++++ v2v/rhv-upload-plugin.py | 2 + v2v/rhv-upload-precheck.py | 55 +++++++--- v2v/rhv-upload-vmcheck.py | 73 +++++++++++++ v2v/types.ml...

...+++ >  v2v/embed.sh                              |  45 ++++ >  v2v/output_rhv_upload.ml <http://output_rhv_upload.ml> >       | 330 ++++++++++++++++++++++++++++++ >  v2v/output_rhv_upload.mli                 |  27 +++ >  v2v/output_rhv_upload_createvm_source.mli |  19 ++ >  v2v/output_rhv_upload_plugin_source.mli   |  19 ++ >  v2v/output_rhv_upload_precheck_source.mli |  19 ++ >  v2v/rhv-upload-createvm.py                |  85 ++++++++ >  v2v/rhv-upload-plugin.py                  | 248 ++++++++++++++++++++++ >...

...Output_rhv_upload_vmcheck_source.code in let plugin_script = - Python_script.create ~name:"rhv-upload-plugin.py" + Python_script.create ~name:"rhv-upload-plugin.py" ~tmpdir Output_rhv_upload_plugin_source.code in let createvm_script = - Python_script.create ~name:"rhv-upload-createvm.py" + Python_script.create ~name:"rhv-upload-createvm.py" ~tmpdir Output_rhv_upload_createvm_source.code in let deletedisks_script = - Python_script.create ~name:"rhv-upload-del...

Previous versions: v3: https://www.redhat.com/archives/libguestfs/2018-March/msg00000.html v2: https://www.redhat.com/archives/libguestfs/2018-February/msg00177.html v1: https://www.redhat.com/archives/libguestfs/2018-February/msg00139.html This completely rethinks the approach taken by the previous patches. Instead of trying to involve qemu's curl driver, this uses a small Python 3

v8 was here: https://www.redhat.com/archives/libguestfs/2018-April/msg00022.html v8 -> v9: - Addresses the only feedback from Tomáš. Rich.

...am | 30 ++- v2v/cmdline.ml | 36 +++ v2v/embed.sh | 45 ++++ v2v/output_rhv_upload.ml | 390 ++++++++++++++++++++++++++++ v2v/output_rhv_upload.mli | 33 +++ v2v/output_rhv_upload_createvm_source.mli | 19 ++ v2v/output_rhv_upload_plugin_source.mli | 19 ++ v2v/output_rhv_upload_precheck_source.mli | 19 ++ v2v/rhv-upload-createvm.py | 85 ++++++ v2v/rhv-upload-plugin.py | 414 ++++++++++++++++++++++++++++++ v2v/rhv-upload-precheck.py...