search for: btrfs_subvolume_show

One of the tests for btrfs_subvolume_show tries to invoke it on the toplevel subvolume, expecting its failure (since btrfs-progs used to not be able to list that). However, since v4.8.3 btrfs-progs can do that (even if the data returned for that subvolume is limited/incomplete), and thus this test fails because the API does not fail anymo...

btrfs_subvolume_show shows the detailed information of a subvolume or snapshot. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- daemon/btrfs.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 9 +++ src/MAX_PROC_NR | 2 +- 3 files changed, 177 insertions(+), 1 de...

btrfs_subvolume_show shows the detailed information of a subvolume or snapshot. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- daemon/btrfs.c | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 9 +++ src/MAX_PROC_NR | 2 +- 3 files changed, 195 insertions(+), 1 de...

On Tue, Dec 02, 2014 at 05:33:32PM +0800, Hu Tao wrote: > btrfs_subvolume_show shows the detailed information of a subvolume or > snapshot. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > daemon/btrfs.c | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++ > generator/actions.ml | 9 +++ > src/MAX_PROC_NR | 2 +- >...

..., qgroupid: Optional[str] = None) -> None: Since the indent function looks for a comma to wrap - this works nicely. However there is this one case where we use the Tuple hint, which contains a comma in itself and causes the following weird line wrapping: def btrfs_subvolume_show(self, subvolume: str) -> Union[List[Tuple[str, str]], dict]: def inspect_get_drive_mappings(self, root: str) -> Union[List[Tuple[str, str]], dict]: def inspect_get_mountpoints(self, root: str) -> Union[List[Tuple[str,...

...ur check did not work anymore. Yes, parsing user messages really sucks... --- daemon/btrfs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 85dbe00..c67af83 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -1029,9 +1029,12 @@ do_btrfs_subvolume_show (const char *subvolume) } /* If the path is the btrfs root, `btrfs subvolume show' reports: - * <path> is btrfs root + * <path> is btrfs root [in btrfs-progs < 4.4] + * <path> is toplevel subvolume */ - if (out && strstr (out, "is btrfs...

On Fri, Nov 21, 2014 at 05:17:13PM +0100, Pino Toscano wrote: > On Friday 21 November 2014 13:18:00 Hu Tao wrote: > > btrfs_subvolume_show shows the detailed information of a subvolume or > > snapshot. > > > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > > --- > > daemon/btrfs.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > generator/actions.ml | 9 +++ > > s...

On Friday 21 November 2014 13:18:00 Hu Tao wrote: > btrfs_subvolume_show shows the detailed information of a subvolume or > snapshot. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > daemon/btrfs.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++ > generator/actions.ml | 9 +++ > src/MAX_PROC_NR | 2 +- >...

On Monday 24 November 2014 16:22:53 Hu Tao wrote: > On Fri, Nov 21, 2014 at 05:17:13PM +0100, Pino Toscano wrote: > > On Friday 21 November 2014 13:18:00 Hu Tao wrote: > > > btrfs_subvolume_show shows the detailed information of a subvolume > > > or > > > snapshot. > > > > > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > > > --- > > > > > > daemon/btrfs.c | 167 > > > ++++++++++++++++++++++++++++++++++...

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu changes: v2: - add 'once_had_no_optargs = true' for btrfs_subvolume_snapshot and btrfs_subvolume_create - improved documents for btrfs_subvolume_snapshot and btrfs_subvolume_create - coding style change (patch 5) - add analyze_line (p...

Since support for python2 is dropped we can use the new python3 syntax for type hints. Signed-off-by: Sam Eiderman <sameid@google.com> --- generator/python.ml | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/generator/python.ml b/generator/python.ml index f0d6b5d96..3640ee39a 100644 --- a/generator/python.ml +++

In btrfs_subvolume_show, an extra check on 'key' is used in a place where this variable is already checked to be non-null. --- daemon/btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index f11902b21..d363ada6d 100644 --- a/daemon/btrfs.c +++ b/daemon/btrf...

...hange it to a hard failure using the List.exists (fun fs' -> fs = g#canonical_device_name fs') ignores in + let is_readonly_btrfs_snapshot fs mp = + try + let is_btrfs = List.mem fs btrfs_filesystems in + if is_btrfs then ( + try + let vol_info = g#btrfs_subvolume_show mp in + string_find (List.assoc "Flags" vol_info) "readonly" <> -1 + with _ -> false + ) else false + with Not_found -> false + in + List.iter ( fun fs -> if not (is_ignored fs) then ( @@ -230,10 +247,15 @@ You can ignore th...

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu Hu Tao (6): btrfs: correct words about subvolume and snapshot btrfs: add optional parameter `ro' to btrfs_subvolume_snapshot btrfs: add optional parameter `qgroupid' to btrfs_subvolume_snapshot btrfs: add optional parameter `qgroupid' to...

...ne btrfs_quota_enable and btrfs_quota_disable - following APIs changed to operate on Mountable_or_Path: btrfs_subvolume_get_default, btrfs_quota_enable, btrfs_quota_rescan. Hu Tao (11): daemon: btrfs: add helper functions mount and umount New API: btrfs_subvolume_get_default New API: btrfs_subvolume_show New API: btrfs_quota_enable New API: btrfs_quota_rescan New API: btrfs_qgroup_limit New API: btrfs_qgroup_create New API: btrfs_qgroup_destroy New API: btrfs_qgroup_show New API: btrfs_qgroup_assign New API: btrfs_qgroup_remove daemon/btrfs.c | 666 ++++++...

...bine btrfs_quota_enable and btrfs_quota_disable - following APIs changed to operate on Mountable_or_Path: btrfs_subvolume_get_default, btrfs_quota_enable, btrfs_quota_rescan. Hu Tao (11): daemon: btrfs: add helper functions mount and umount New API: btrfs_subvolume_get_default New API: btrfs_subvolume_show New API: btrfs_quota_enable New API: btrfs_quota_rescan New API: btrfs_qgroup_limit New API: btrfs_qgroup_create New API: btrfs_qgroup_destroy New API: btrfs_qgroup_show New API: btrfs_qgroup_assign New API: btrfs_qgroup_remove daemon/btrfs.c | 664 ++++++...

On Wednesday 26 November 2014 17:04:03 Hu Tao wrote: > This is the part1 of improving btrfs support. This series adds missing > parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and > adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. > > Other parts will follow. > > Regards, > Hu > > changes: > v2: > - add 'once_had_no_optargs = true' for btrfs_subvolume_snapshot and > btrfs_subvolume_create > - improved documents for btrfs_subvolume_snapshot and > btrfs_subvolume_crea...

Hi, This series adds support to btrfs qgroup related commands, inclduing quota commands, and two leftover of subvolume commands. Regards, Hu Hu Tao (8): New API: btrfs_subvolume_get_default New API: btrfs_subvolume_show New API: btrfs_quota_enable New API: btrfs_quota_disable New API: btrfs_quota_rescan New API: btrfs_qgroup_limit New API: btrfs_qgroup_create New API: btrfs_qgroup_destroy daemon/btrfs.c | 412 +++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 73 ++++++...

...length file - 9) in if not (Sys.file_exists file) then error (f_"--tmp prebuilt:file: %s: file does not exist") file; @@ -224,7 +224,7 @@ You can ignore this warning or change it to a hard failure using the if is_btrfs then ( try let vol_info = g#btrfs_subvolume_show mp in - string_find (List.assoc "Flags" vol_info) "readonly" <> -1 + String.find (List.assoc "Flags" vol_info) "readonly" <> -1 with G.Error _ -> false ) else false with Not_found -> false @@ -295,7 +29...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.